HTTP/2 request content upload stalls when response headers are received #10433
Assignees
Labels
Comments
|
I believe @icing has a fix for this? |
|
I have indeed. Will make a PR tomorrow pbly. |
icing
added a commit
to icing/curl
that referenced
this issue
Feb 8, 2023
…s set. - as reported in curl#10433, HTTP/2 uploads may stall when a response is received before the upload is done. This happens when the data->state.drain is set for such a transfer, as the special handling in transfer.c from then on only cared about downloads. - add continuation of uploads, if applicable, in this case. - add pytest case test_07_12_upload_seq_large to reproduce this scenario (although, current nghttp2 implementation is using drain less often)
|
Fix and test case for this in #10443. |
bch
pushed a commit
to bch/curl
that referenced
this issue
Jul 19, 2023
- as reported in curl#10433, HTTP/2 uploads may stall when a response is received before the upload is done. This happens when the data->state.drain is set for such a transfer, as the special handling in transfer.c from then on only cared about downloads. - add continuation of uploads, if applicable, in this case. - add pytest case test_07_12_upload_seq_large to reproduce this scenario (although, current nghttp2 implementation is using drain less often) Reported-by: Lucas Pardue Fixes curl#10433 Closes curl#10443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did this
Scenario: a curl client POSTing a large file (say over 100 KB) to an HTTP/2 server that is configured to respond immediately before a) waiting for all of the indicated content-length to be received or b) waiting for the request stream FIN. Note that this server also leaves the response side open until it detects the client closes its side.
I'm aware of reports that in such a scenario, once curl receives the response, the upload no longer progresses. For servers that have some kind of body read timeout (e.g. http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_send_timeout) this means that the stream or connection is eventually timed and reset or closed with an error
I expected the following
When a response is received before curl completes a request upload, and the server has not closed its side, curl should continue the upload.
curl/libcurl version
One confirmed report with an old verion
Uncomfirmed reports with later versions exhibit the same behaviour.
operating system
The text was updated successfully, but these errors were encountered: