doh: Optimization for disabled ENABLE_IPV6 #10397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For disabled IPv6 a condition (conn->ip_version != CURL_IPRESOLVE_V4) is always false. https://pvs-studio.com/en/docs/warnings/v560/
|
The title says "Code is unusable without ENABLE_IPV6" but it seems this is just an optimization? |
kvarec
changed the title
fixed |
bagder
approved these changes
Feb 2, 2023
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
For disabled IPv6 a condition (conn->ip_version != CURL_IPRESOLVE_V4) is always false. https://pvs-studio.com/en/docs/warnings/v560/ Closes curl#10397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For disabled IPv6 a condition (conn->ip_version != CURL_IPRESOLVE_V4) is always false.
https://pvs-studio.com/en/docs/warnings/v560/