[docs] Fix memory leak in example for CURLOPT_WRITE_FUNCTION
#10390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Feb 1, 2023
| @@ -109,6 +109,9 @@ For all protocols | |||
|
|
|||
| /* we pass our 'chunk' struct to the callback function */ | |||
| curl_easy_setopt(curl_handle, CURLOPT_WRITEDATA, (void *)&chunk); | |||
|
|
|||
| /* remember to free the buffer */ | |||
| free(chunk.response) | |||
There was a problem hiding this comment.
Well, at this point in the code this free() call will do no good since it hasn't had the chance to allocate anything yet!
Shouldn't you then also perhaps invoke curl_easy_perform() before the free is called?
There was a problem hiding this comment.
Yes. I also fixed all remaining errors, i.e. curl_handle coming out of nowhere.
bagder
approved these changes
Feb 3, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10387