Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: remove the peeps mentioned as CI owners #10386

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 1, 2023

These owners do not have the bandwidth/energy to do the reviews which makes PRs stall and this ownership claim flawed.

Follow-up to c04c78a

These owners do not have the bandwidth/energy to do the reviews which
makes PRs stall and this ownership claim flawed.

Follow-up to c04c78a
@github-actions github-actions bot added the CI Continuous Integration label Feb 1, 2023
@cmeister2
Copy link
Contributor

Hmm. I wouldn't say that I don't have the energy here; I feel like I lack authority to be approving changes. There's also changes where I don't feel as though I'm an expert, and so don't comment.

I'm unsure how you want to proceed. If you feel like this experiment hadn't borne the fruit we hoped for, then it's your project: happy to approve this. Alternatively, happy to have this as a venue for discussion on adaptation?

@bagder
Copy link
Member Author

bagder commented Feb 1, 2023

I don't think asking for a review is saying you need to have a mandate to do anything in particular other than to give your opinion and "judgement" about a proposed change, and perhaps in particular the way it is done.

The effect we have now is that we assign CI related PRs for reviews that then just sit there without anyone actually doing the reviews (and with two people already assigned the job, it deters others to do it since it looks like the job is already "taken"). I think it looks bad as well when eventually I override the non-provided reviews and go ahead and review it myself or just merge it with one or two pending reviews.

I don't think this process helps; I think it hurts.

For auto-assigning reviews, I would expect that the asignees at least usually fulfill the task as otherwise why do it automatically in the first place?

@cmeister2
Copy link
Contributor

Fair point. I've approved.

@bagder bagder closed this in b7aaf07 Feb 2, 2023
@bagder bagder deleted the bagder/blank-CODEOWNERS branch February 2, 2023 07:43
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
These owners do not have the bandwidth/energy to do the reviews which
makes PRs stall and this ownership claim flawed. We can bring people
back when the situation is different.

Follow-up to c04c78a

Closes curl#10386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Development

Successfully merging this pull request may close these issues.

None yet

2 participants