Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlapi: avoid Curl_dyn_addf() for hex outputs #10384

Closed
wants to merge 2 commits into from
Closed

urlapi: avoid Curl_dyn_addf() for hex outputs #10384

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 1, 2023

inspired by the recent fixes to escape.c, we really should avoid calling Curl_dyn_addf() in loops, perhaps in particular when adding something so simple such as %HH codes - for performance reasons. This change thus makes the same thing for the URL parser's two URL-encoding loops.

@bagder bagder closed this in 7305ca6 Feb 1, 2023
@bagder bagder deleted the bagder/less-dyn_addf branch February 1, 2023 22:10
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
urlapi: avoid Curl_dyn_addf() for hex outputs
19a46eb 
Inspired by the recent fixes to escape.c, we should avoid calling
Curl_dyn_addf() in loops, perhaps in particular when adding something so
simple as %HH codes - for performance reasons. This change makes the
same thing for the URL parser's two URL-encoding loops.

Closes curl#10384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance URL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder