escape: hex decode with a lookup-table #10376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the decoding 2.8 times faster in my tests.
bagder
force-pushed
the
bagder/urldecode-faster
branch
from
edddbd3
to
ffcc1a6
Compare
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Makes the decoding 2.8 times faster in my tests. Closes curl#10376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster URL decodes in curl
I wrote a test program that uses a 1MB buffer in which byte sequences are stored from 0 to 255 over and over.
Then
curl_easy_escape()is called, to generate a URL encoded version of that input.curl_easy_unescape()is then called repeatedly to decode that huge string and I measure the time needed for it to complete 10000 iterations.On my dev host, the new code runs 2.8 times faster.