Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: delete redundant macro definition SECURITY_WIN32 #10341

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 24, 2023

Stop explicitly defining SECURITY_WIN32 in CMake builds.

No other build system defines this macro, because it's unconditionally defined in lib/curl_sspi.h already. This is the only curl source using the sspi.h and security.h Win32 headers, and no other Win32 headers need this macro.

Closes #xxxxx

Stop explicitly defining `SECURITY_WIN32` in CMake builds.

No other build system defines this macro, because it is unconditionally
defined in `lib/curl_sspi.h` already. This is the only curl source using
the `sspi.h` and `security.h` Win32 headers, and no other Win32 headers
need this macro.

Closes #xxxxx
@vszakats vszakats changed the title cmake: delete redundant macro cmake: delete redundant macro definition SECURITY_WIN32 Jan 24, 2023
@vszakats vszakats added cmake Windows Windows-specific tidy-up labels Jan 24, 2023
@vszakats vszakats closed this in c0958b7 Jan 25, 2023
@vszakats vszakats deleted the cmake-win-unused-def-1 branch February 2, 2023 11:45
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Stop explicitly defining `SECURITY_WIN32` in CMake builds.

No other build systems define this macro, because it's unconditionally
defined in `lib/curl_sspi.h` already. This is the only curl source using
the `sspi.h` and `security.h` Win32 headers, and no other Win32 headers
need this macro.

Reviewed-by: Jay Satiro
Closes curl#10341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants