Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove that --proto is just used for initial retrieval #1031

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Sep 21, 2016

.. and add that --proto-redir and CURLOPT_REDIR_PROTOCOLS do not
override protocols denied by --proto and CURLOPT_PROTOCOLS.

  • Add a test to enforce: --proto deny must override --proto-redir allow

I think saying "Tells curl to use the listed protocols for its initial retrieval" in --proto is misleading because protocols it denies can't be used on redirect, so I changed it to "Tells curl to limit what protocols it may use in the transfer" and added a test to make sure it stays that way. I wasn't able to go further back than 7.21 but I'd guess this holds true since inception.

.. and add that --proto-redir and CURLOPT_REDIR_PROTOCOLS do not
override protocols denied by --proto and CURLOPT_PROTOCOLS.

- Add a test to enforce: --proto deny must override --proto-redir allow
@bagder
Copy link
Member

bagder commented Sep 21, 2016

I think that wording came from me trying to make it clear that it was affecting already the first request, as opposed to the redir version that only affects what it allows a redirect to. I think your change here is a clear improvement!

@jay jay closed this in 36e53ec Sep 21, 2016
@jay jay deleted the proto_deny_overrides_proto-redir branch September 21, 2016 21:24
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants