connect: fix access of pointer before NULL check #10284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected by Coverity CID 1518992
icing
approved these changes
Jan 12, 2023
| @@ -677,7 +677,9 @@ static CURLcode is_connected(struct Curl_cfilter *cf, | |||
| for(i = 0; i < sizeof(ctx->baller)/sizeof(ctx->baller[0]); i++) { | |||
| struct eyeballer *baller = ctx->baller[i]; | |||
| DEBUGF(LOG_CF(data, cf, "%s assess started=%d, result=%d", | |||
| baller->name, baller->has_started, baller->result)); | |||
| baller?baller->name:NULL, | |||
There was a problem hiding this comment.
Seems wise and necessary, yes.
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Detected by Coverity CID 1518992 Closes curl#10284
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 11, 2023
Seen with gcc 13.2.0 on Debian: https://github.com/curl/curl-for-win/actions/runs/6476161689/job/17584426483#step:3:11104 Ref: curl#10284 Co-authored-by: Jay Satiro Closes curl#12082
vszakats
added a commit
that referenced
this pull request
Oct 13, 2023
Do not pass NULL to printf %s. Seen with gcc 13.2.0 on Debian: ``` .../curl/lib/connect.c:696:27: warning: '%s' directive argument is null [-Wformat-overflow=] ``` Ref: https://github.com/curl/curl-for-win/actions/runs/6476161689/job/17584426483#step:3:11104 Ref: #10284 Co-authored-by: Jay Satiro Closes #12082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by Coverity CID 1518992