Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat CMAKE_REQUIRED_DEFINITIONS as a list #10272

Closed
wants to merge 1 commit into from
Closed

Treat CMAKE_REQUIRED_DEFINITIONS as a list #10272

wants to merge 1 commit into from

Conversation

Marc-Aldorasi-Imprivata
Copy link
Contributor

According to the documentation CMAKE_REQUIRED_DEFINITIONS is a list, so add to it using list(APPEND instead of string concatenation.

@bagder bagder added the cmake label Jan 10, 2023
@jay jay added the tidy-up label Jan 24, 2023
@jay jay closed this in 71cc27f Jan 24, 2023
@jay
Copy link
Member

jay commented Jan 24, 2023

Thanks

bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@Marc-Aldorasi-Imprivata @bch
cmake: use list APPEND syntax for CMAKE_REQUIRED_DEFINITIONS
700966a 
- Use list() instead of set() for CMAKE_REQUIRED_DEFINITIONS list since
  the former is clearer.

Closes curl#10272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzakrzewski jzakrzewski Awaiting requested review from jzakrzewski

Assignees
No one assigned
Labels
cmake tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Marc-Aldorasi-Imprivata @jay @bagder