curl -D headerfile to use append only operations #10224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sfer started to be the first to get a response. All transfers now write the headefile (-D) in append mode, making sure that the order of transfer responses does not lead to overwrites of previous data.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| newfile = fopen(config->headerfile, "wb+"); | ||
| fclose(newfile); | ||
| } | ||
| newfile = fopen(config->headerfile, "ab+"); |
Check failure
Code scanning / CodeQL
File created without restricting permissions
bagder
approved these changes
Jan 4, 2023
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Do not rely on the first transfer started to be the first to get a response (remember -Z). All transfers now write the headefile (-D) in append mode, making sure that the order of transfer responses does not lead to overwrites of previous data. Closes curl#10224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix headerfile writing in the curl tool to not rely on the first transfer started to be the first to get a response.
All transfers now write the headefile (-D) in append mode, making sure that the order of transfer responses does not lead to overwrites of previous data.