Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urldata: stop storing TLS auth type #10181

Closed
wants to merge 2 commits into from
Closed

urldata: stop storing TLS auth type #10181

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Dec 30, 2022

The only TLS auth type libcurl ever supported is SRP and that is the default type. Since nobody ever sets any other type, there is no point in wasting space to store the set type and code to check the type.

If TLS auth is used, SRP is now implied.

@bagder
urldata: stop storing TLS auth type
ee9a53b 
The only TLS auth type libcurl ever supported is SRP and that is the
default type. Since nobody ever sets any other type, there is no point
in wasting space to store the set type and code to check the type.

If TLS auth is used, SRP is now implied.
@bagder bagder added the TLS label Dec 30, 2022
@bagder bagder closed this in becfe2e Dec 31, 2022
@bagder bagder deleted the bagder/forget-authtype branch December 31, 2022 15:57
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
urldata: cease storing TLS auth type
d1a069b 
The only TLS auth type libcurl ever supported is SRP and that is the
default type. Since nobody ever sets any other type, there is no point
in wasting space to store the set type and code to check the type.

If TLS auth is used, SRP is now implied.

Closes curl#10181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder