Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socks: fix username max size is 255 (0xFF) #10105

Closed
wants to merge 1 commit into from
Closed

socks: fix username max size is 255 (0xFF) #10105

wants to merge 1 commit into from

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Dec 16, 2022

curl/lib/socks.c

Lines 681 to 687 in 50e781d

/* username/password request looks like
* +----+------+----------+------+----------+
* |VER | ULEN | UNAME | PLEN | PASSWD |
* +----+------+----------+------+----------+
* | 1 | 1 | 1 to 255 | 1 | 1 to 255 |
* +----+------+----------+------+----------+
*/

danielgustafsson
danielgustafsson approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this looks like a correct fix. Seems like commit f4b6901 got the username length check wrong but the password length check right.

@bagder bagder closed this in 6cc1880 Dec 16, 2022
@bagder
Copy link
Member

bagder commented Dec 16, 2022

Thanks!

@0x0a0d 0x0a0d deleted the fix_socks_username_length branch September 21, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@danielgustafsson danielgustafsson danielgustafsson approved these changes

Assignees
No one assigned
Labels
connecting & proxies
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x0a0d @bagder @danielgustafsson