config-mac: define HAVE_SYS_IOCTL_H #10042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/config-mac.h
Outdated
| @@ -53,6 +53,7 @@ | |||
| #define HAVE_UTIME_H 1 | |||
| #define HAVE_SYS_TIME_H 1 | |||
| #define HAVE_SYS_UTIME_H 1 | |||
| #define HAVE_SYS_FILIO_H 1 | |||
There was a problem hiding this comment.
Daft question since I don't know Mac OS other than as a user (a long time ago..). Is filio.h available on all versions of Mac OS on which it would be feasible to build libcurl? In other words, does it go further back than OS9?
Disclaimer: I'm mainly curious, I don't think it's a problem to define this if it doesn't
There was a problem hiding this comment.
Classic Mac OS does not have filio.h or other Unix headers. To build curl on classic Mac OS, the Grand Unified Socket Interface (GUSI) is required. It provides an early 2000s Unix-like socket and threads interface for classic Mac OS. It is compatible with System 7, Mac OS 8, and Mac OS 9.
Define HAVE_SYS_IOCTL_H in config-mac.h. This is needed to compile nonblock.c on classic Mac OS with GUSI because nonblock.c uses FIONBIO which is defined in <sys/filio.h> which is included by <sys/ioctl.h>.
ryandesign
force-pushed
the
ryandesign-sys-filio.h
branch
from
2353acf
to
84cd2d7
Compare
ryandesign
changed the title
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefineHAVE_SYS_FILIO_Hin config-mac.h and include <sys/filio.h> in nonblock.c whenHAVE_SYS_FILIO_His defined.Define
HAVE_SYS_IOCTL_Hin config-mac.h. This is needed to compile nonblock.c on classic Mac OS with GUSI because nonblock.c usesFIONBIOwhich is defined in <sys/filio.h> which is included by <sys/ioctl.h>.