curl / Mailing Lists / curl-library / Single Mail
Buy commercial curl support from WolfSSL. We help you work out your issues, debug your libcurl applications, use the API, port to new platforms, add new features and more. With a team lead by the curl founder himself.

Re: Verifying #10562 on Windows before tomorrow

From: Douglas R. Reno via curl-library <curl-library_at_lists.haxx.se>
Date: Sun, 19 Feb 2023 13:58:40 -0600

On 2/19/2023 10:29 AM, Daniel Stenberg via curl-library wrote:
> Hi,
>
> In case there is someone building curl from source on Windows, it
> would be awesome we could get some help asap to verify that #10562
> fixes the #10561 problem!
>
> I want to merge the fix before tomorrow morning my time, or at worst
> revert back to pre 7.88.0 status.
>
> How to verify:
>
>  1. build curl from git master, apply the #10562 patch
>  2. run the following [1] in a bat file and it should not cause any
> problems
>
> FOR /L %%G IN (1,1,%MAX%) DO (
>   curld -sS -f -H "Connection: close" https://httpd.apache.org/ -o NUL
> --write-out "%%{time_total} "
>   if !ERRORLEVEL! NEQ 0 exit /b 1
> )
>
> (You can change the target URL, it can probably also just be "curl.se".)
>
> [1] = https://github.com/curl/curl/issues/10561#issuecomment-1435932103
>
Hi Daniel,

I applied the pull request and then run a build in Visual Studio 2019
using "generate.bat vc142" and then opening the curl-all solution in
Visual Studio. I set my configuration to "DLL - Release - DLL Windows
SSPI - DLL WinIDN" and the build succeeded.

After this I modified the batch file that you provided in this mailing
list post a bit since there is no %MAX% on my system, and Cloudflare
appeared to be getting in my way after a few attempts. What I did
instead was:

_at_echo off
FOR /L %%G IN (1, 1, 5000) DO (
     .\curl.exe -sS -f -H "Connection: close"
https://www.linuxfromscratch.org/ -o NUL --write-out "%%{time_total} "
)

Reviewing the output shows a bunch of results that are most definitely
times (and no connection reset errors or any other error output), so I
think this problem has been fixed. :)

Tested on Windows 7, Server 2012 R2, Windows 10, and Windows 11.

Thank you,
Douglas R. Reno (renodr on github)

-- 
Unsubscribe: https://lists.haxx.se/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html
Received on 2023-02-19